mockito 2.0.14 fails to mock jetty httpclient

[christophsturm]

this fails:

     import org.eclipse.jetty.client.HttpClient;
    HttpClient httpClient = mock(HttpClient.class);

(jetty 9.2.10.v20150310)

with mockito 2.0.2-beta i can mock that class without a problem.

stacktrace:

java.lang.IllegalAccessError: tried to access class org.eclipse.jetty.util.component.ContainerLifeCycle$Managed from class org.eclipse.jetty.client.HttpClient$MockitoMock$362486671
    at org.eclipse.jetty.client.HttpClient$MockitoMock$362486671.(Unknown Source)
    at sun.reflect.GeneratedSerializationConstructorAccessor2.newInstance(Unknown Source)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:408)
    at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:45)
    at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:73)
    at org.mockito.internal.creation.instance.ObjenesisInstantiator.newInstance(ObjenesisInstantiator.java:14)
    at org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:27)
    at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:33)
    at org.mockito.internal.MockitoCore.mock(MockitoCore.java:59)
    at org.mockito.Mockito.mock(Mockito.java:1392)
    at org.mockito.Mockito.mock(Mockito.java:1270)

[bric3]

Is this an OSGI package ?

[bric3]

Also a general principle when mocking is to not mock types you don't own, there's several reasons for that see that wiki page.

However the issue is probably true. But I cannot reproduce locally, do you have additional informations like jetty version, jvm version (OpenJDK, hotspot, J9, ...) ?

[christophsturm]

yeah, i know about that rule. this is from a really tiny method and i just want to check that it invokes the start method.

oracle jdk8_11, jetty 9.2.10

[raphw]

The Managed inner class is package-private: http://grepcode.com/file/repo1.maven.org/maven2/org.eclipse.jetty/jetty-util/9.1.3.v20140225/org/eclipse/jetty/util/component/ContainerLifeCycle.java#ContainerLifeCycle.Managed

This class should never be accessible from org.eclipse.jetty.client.HttpClient or any mock which both live in another package. I assume that you have a version clash on your class path. Creating a mock can trigger lazy class path resolutions that are not even triggered in your production code via the class introspection that is required to create the mock.

[christophsturm]

ok but the HttpClient class can be instantiated just fine by calling its constructor

client = new HttpClient();

[christophsturm]

also the managed enum is only used inside ContainerLifeCycle.

[raphw]

I now see what the problem is. Byte Buddy overrides the public method ContainerLifeCycle::addBean(Object o, Managed managed) in order to allow mocking the method call. For this, the mock references the Managed class which is however package-private.

While this is a rather poorly designed API as the method should itself be package-private as it cannot be used outside of the package, Byte Buddy should be smart enough to figure this out. It is a small fix, I have it ready some time this week. Thanks for reporting!

[christophsturm]

thanks. I agree that the package structure and api design of jetty is a bit strange.

[bric3]

@raphw Thanks for the investigation

[bric3]

@christophsturm Thanks for the feddback too, note mockito 2.0.0 is still in beta phase

[christophsturm]

sure! we will just continue to use 2.0.2-beta for now which works great.

[bric3]

You can use a more recent beta 2.0.8-beta, the last version before switching to bytebuddy

[raphw]

Byte Buddy 0.6.9 is released which should fix the issue. Sorry for the hick-up. (In JCenter, currently synchronizing to Maven Central.)

[bric3]

No problem, you were blazingly fast !