Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the tests use mock maker with intended member accessor #2855

Closed
5 tasks
reta opened this issue Jan 9, 2023 · 1 comment · Fixed by #2872
Closed
5 tasks

Make sure the tests use mock maker with intended member accessor #2855

reta opened this issue Jan 9, 2023 · 1 comment · Fixed by #2872

Comments

@reta
Copy link
Contributor

reta commented Jan 9, 2023

It seems like there is a gap in tests: the tests get mock maker instance (from environment setting) but not the member accessor it supposed to be used with. As such, the tests used reflection, not module accessor, all the time (see please #2834 (comment)).

check that

  • The mockito message in the stacktrace have useful information, but it didn't help
  • The problematic code (if that's possible) is copied here;
    Note that some configuration are impossible to mock via Mockito
  • Provide versions (mockito / jdk / os / any other relevant information)
  • Provide a Short, Self Contained, Correct (Compilable), Example of the issue
    (same as any question on stackoverflow.com)
  • Read the contributing guide

@TimvdLippe I could take it if you don't mind, thank you

@TimvdLippe
Copy link
Contributor

Go ahead 👍

TimvdLippe pushed a commit that referenced this issue Jan 19, 2023
Fixes #2855

Signed-off-by: Andriy Redko <drreta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants