Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function name is incorrect. #2955

Closed
ByoungJoonIm opened this issue Mar 31, 2023 · 2 comments · Fixed by #3020
Closed

Function name is incorrect. #2955

ByoungJoonIm opened this issue Mar 31, 2023 · 2 comments · Fixed by #3020
Labels
please contribute

Comments

@ByoungJoonIm
Copy link

I saw DoAnswerStyleStubbing class code.
I thought that below is correct.

boolean isSet() {
    return !answers.isEmpty();
}

After execute setAnswers function with answers, instance will return isSet is false.
I think it looks strange.

And InvocationContainerImpl also need to be changed as follow.

public boolean hasAnswersForStubbing() {
    return doAnswerStyleStubbing.isSet();
}
@TimvdLippe
Copy link
Contributor

@ByoungJoonIm Feel free to send us a PR that fixes this.

undermyumbrella1 pushed a commit to undermyumbrella1/mockito that referenced this issue May 25, 2023
Fixes mockito#2955
8eb2572
@undermyumbrella1 undermyumbrella1 mentioned this issue May 25, 2023
Merged
@undermyumbrella1
Copy link
Contributor

Hi I made a pr that fixes this, thank you

TimvdLippe pushed a commit that referenced this issue May 25, 2023
@undermyumbrella1
Edit DoAnswerStyleStubbing.isSet() to return true if there are answers (
2280cac 
#3020)

Fixes #2955

---------

Co-authored-by: Kei <keiwork111@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
please contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit DoAnswerStyleStubbing.isSet() to return true if there are answers undermyumbrella1/mockito
3 participants
@TimvdLippe @ByoungJoonIm @undermyumbrella1