Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential editorconfig enhancement #3347

Closed
christopher-spires opened this issue May 17, 2024 · 2 comments · Fixed by #3353
Closed

potential editorconfig enhancement #3347

christopher-spires opened this issue May 17, 2024 · 2 comments · Fixed by #3353

Comments

@christopher-spires
Copy link

I noticed that the CONTRIBUTING.md file has IntelliJ IDEA instructions. But those settings are not in the .editorconfig file. May have been added to IntelliJ since the last time that file was generated.

i.e.

[*]
charset = utf-8
[*.java]
ij_java_align_multiline_throws_list = true
ij_java_align_multiline_annotation_parameters = true
ij_java_annotation_parameter_wrap = off
ij_java_blank_lines_after_imports = 1
ij_java_blank_lines_before_imports = 1
ij_java_class_count_to_use_import_on_demand = 100
ij_java_imports_layout = static java.**,static javax.**,$*,|,java.**,javax.**,*
ij_java_insert_inner_class_imports = true
ij_java_layout_static_imports_separately = true
ij_java_method_call_chain_wrap = off
ij_java_names_count_to_use_import_on_demand = 100
ij_java_throws_list_wrap = off

( I think those are the one listed in the file but not in .editorconfig file)

@TimvdLippe
Copy link
Contributor

Feel free to contribute! In any case, for auto-formatting we run ./gradlew spotlessApply

@thachlp thachlp mentioned this issue May 23, 2024
3 tasks
@thachlp
Copy link
Contributor

thachlp commented May 23, 2024

Hi @TimvdLippe @christopher-spires, I created a pr for this, please help review

TimvdLippe pushed a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants