Provide Java 9 compatibility

[szpak]

Once having Mockito 2.0 out the door it would be good to explore Java 9 compatibility.

Basic todo list:

• - migration to Gradle 3.0 (2.x doesn't support Java 9)
• - Travis build with Java 9
• - successful Mockito project build with Java 9
• - fix all disabled tests when the new ASM version is available - Reenable tests disabled for Java 9 when new ASM is available #863

Open Java 9 related issues.

[bric3]

I agree with that however note that mockito 2.1 should still be Java 5 compatible (we still build Java 5 binaries with Java 6).
Before that we need to branch mockito 2.x to support old JDKs and make mockito 3 Java 8 min.

[szpak]

we still build Java 5 binaries with Java 6

I'm afraid we are not:

sourceCompatibility = 1.6
targetCompatibility = 1.6

If Java 5 is in fact a target of Mockito 2.0 I could add Animal sniffer verification that we don't use Java 6 API in the code.

We would probably need to decide if 2.1 is just for things that were able to finish before 2.0-final (and important bugfixes) or there are plans to keep a serious development of 2.x line after 2.1 (with backporting non Java 8 specific changes from 3.x branch).

[bric3]

Damn I didn't see this change. I'm on my phone.

However that's fine for me.

[bric3]

Maybe something to mention in the migration guide though.

[bric3]

Otherwise for 2.1 I think we will only include few API refactoring like ArgumentCaptor. And bugfixes otherwise it will delay serious work on mockito 3.
Also I don't want to backport java 8 code to mockito 2.
My idea is to have a 2.x branch, we can adjust the build script to release on this branch too.

[raphw]

Just for information, the parts Mockito uses of Byte Buddy are already fully Java 9 compatible. I do not see any problems on migration.

[TimvdLippe]

I think this is ready now?

[raphw]

ASM 6 is still in alpha: http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.ow2.asm%22%20AND%20a%3A%22asm%22

[bric3]

Really don't focus too much on Java 9 it's still months away.

[ceki]

For your information, logback uses Mockito version 1.10.19 which is apparently not Java 9 compatible. It follows that logback build fails under Java 9.

[raphw]

Mockito 2 is Java 9 compatible.

[ceki]

Great. Thank you.

[sdfelts]

Running on version 1.9.5 with Jigsaw b162 with --permit-illegal-access.

I'm seeing the following warning.
WARNING: Illegal access by org.mockito.cglib.core.ReflectUtils$2 (file:gradle_cache/caches/modules-2/files-2.1/org.mockito/mockito-all/1.9.5/79a8984096fc6591c1e3690e07d41be506356fa5/mockito-all-1.9.5.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)

Maybe related:
WARNING: Illegal access by net.sf.cglib.core.ReflectUtils$1 (file:gradle_cache/caches/modules-2/files-2.1/cglib/cglib-nodep/3.2.4/42c972dee25a436b32c6027e848287ff47ed6750/cglib-nodep-3.2.4.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)

Is this fixed in 2.x? Or is there handling if this call fails?

[TimvdLippe]

It might be fixed with Mockito 2 yes, as we are not using CGLib anymore. No promises though 😉

[sdfelts]

I confirmed that the org.mockito.cglib.core.ReflectUtils is gone in 2.x and mockito no longer depends on net.sf.cglib.core.

[raphw]

Byte Buddy 1.7.2 now supports Java 9 class files.

[mockitoguy]

Byte Buddy 1.7.2 now supports Java 9 class files.

Should we just bump bytebuddy to the latest version? Cheers!

[TimvdLippe]

Closing as at last #863 has been fixed as well. Java 9 woohoo 🎉