Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix again javadoc stylesheet #552

Closed
bric3 opened this issue Aug 13, 2016 · 4 comments
Closed

Fix again javadoc stylesheet #552

bric3 opened this issue Aug 13, 2016 · 4 comments
Assignees
@bric3
Labels
docs
Milestone
2.1

Comments

@bric3
Copy link
Contributor

bric3 commented Aug 13, 2016

Previously we had a nice javadoc stylesheet. That worked well with JDK6.
Then we used travis that was only allowing OracleJDK7, that came with a better javadoc stylesheet so we dropped ours.

Now since the release of mockito 2.x is using openjdk6, we should reintroduce a better stylesheet.

Current state ❌
http://site.mockito.org/mockito/docs/2.0.100-beta/org/mockito/Mockito.html
screen shot 2016-08-13 at 19 41 59

Previous ✅
http://site.mockito.org/mockito/docs/2.0.0-beta/org/mockito/Mockito.html
screen shot 2016-08-13 at 19 45 32
@bric3 bric3 added the docs label Aug 13, 2016
@bric3 bric3 added this to the 2.0 milestone Aug 13, 2016
@TimvdLippe
Copy link
Contributor

Is this as simple as turning back on this line?

mockito/gradle/javadoc.gradle

Line 55 in b0393ea

// options.stylesheetFile file("src/javadoc/stylesheet.css")

@bric3
Copy link
Contributor Author

bric3 commented Aug 15, 2016

Probably but I need to check before. The file may have been removed. And the javadoc tool is picky especially in old version of the JDK.

@bric3 bric3 added the ready label Aug 22, 2016
@bric3
Copy link
Contributor Author

bric3 commented Aug 23, 2016

Actually we should revert this commit 3a057b3, when JDK7 was the only option on travis

bric3 added a commit that referenced this issue Aug 23, 2016
@bric3
Fixes #552
7611b4c
@bric3 bric3 mentioned this issue Aug 23, 2016
Merged
@bric3 bric3 self-assigned this Aug 23, 2016
@bric3 bric3 added in progress and removed ready labels Aug 23, 2016
bric3 added a commit to bric3/mockito that referenced this issue Aug 23, 2016
@bric3
Fixes mockito#552 by reverting 3a057b3
f2c4474 
At that time oracle JDK 7 was the only option with travis. This JDK version had a better javadoc rendering.
so we removed our own style sheet, since travis added openjdk6, we decided to build the artefacts with this JDK.
Which made the javadoc look bad again. This commit changes that.
@bric3 bric3 removed the in progress label Aug 23, 2016
@bric3
Copy link
Contributor Author

bric3 commented Aug 24, 2016

It seems the javadoc tool of openjdk6 generates a different HTML than Sun JDK 6. Thus the stylesheet is not working properly.

screen shot 2016-08-24 at 11 56 56

Yet again an issue with OpenJDK6...

@bric3 bric3 mentioned this issue Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bric3 bric3

Labels
docs
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@bric3 @TimvdLippe