-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failing with Java 9-ea+146+ #1007
Conversation
Stack trace in JDK part contains also module name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change seems fine to me. Have not actually run into this issue with JDK 9, but havent run the tests locally for a long time anyways :p
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
============================================
- Coverage 86.58% 86.56% -0.02%
+ Complexity 2203 2202 -1
============================================
Files 286 286
Lines 5680 5680
Branches 658 658
============================================
- Hits 4918 4917 -1
- Misses 568 571 +3
+ Partials 194 192 -2
Continue to review full report at Codecov.
|
Tested with Java 8 and Java 9-ea+146. Newer Java 9 versions (up to 9-ea+162) throws |
Hm, hopefully known Gradle bug. If anyone can test and verify, that would be nice. Else I will merge this tomorrow :) |
Never mind, merged already 😂 |
Yup, known bug - gradle/gradle#1095. |
Although there seems to be a workaround: gradle/gradle#719 (comment) (just as a reference). |
@szpak, thanks a lot for the fix!!! BTW. do you know if we can set up travis build with java 9? |
@szczepiq In fact Mockito master is already built with Java 9. Just not that fresh version to trigger mentioned issue. On the other hand, Gradle is not compatible with more recent Java 9 versions. |
Stack trace in JDK part contains also module name:
The new regexp handles both variants.