Removed JDK7 build from CI to fix Travis regression with Jdk7 #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mockito ticket: #1182 Travis CI ticket: travis-ci/travis-ci#7884
- I have tried to get the build working with jdk7 but I couldn't get it to work. I kept getting: Exception in thread "main" javax.net.ssl.SSLException: java.security.ProviderException. We remember this issue from our Jdk6 build, we could not fix it and eventually we have stopped building with Jdk6. - We still publish with Java6 compatibility and we have animal sniffer set up to catch regressions. It should be ok to build only on Jdk8. - Jdk6 and jdk7 has been deprecated years ago, we need to move on.
Codecov Report
@@ Coverage Diff @@
## release/2.x #1184 +/- ##
=================================================
- Coverage 86.93% 86.67% -0.26%
- Complexity 2299 2309 +10
=================================================
Files 287 287
Lines 5825 5900 +75
Branches 686 703 +17
=================================================
+ Hits 5064 5114 +50
- Misses 564 585 +21
- Partials 197 201 +4
Continue to review full report at Codecov.
|
mockitoguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reference:
Details:
Exception in thread "main" javax.net.ssl.SSLException: java.security.ProviderException.We remember this issue from our Jdk6 build, we could not fix it and eventually we have stopped building with Jdk6.