Make MockitoExtension constructor public #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to register an extension for automatic use using Java's `ServiceLoader` mechanism. https://junit.org/junit5/docs/current/user-guide/#extensions-registration-automatic Some projects may want to provide their own `META-INF` file to avoid tediously adding `MockitoExtension` to tests since it is very common. However, `ServiceLoader` requires the class to have a no-args *public* constructor, so the current extension cannot be used with the `ServiceLoader` mechanism.
TimvdLippe
approved these changes
May 17, 2018
|
Would be great if you could add a test for this. Not sure if that is possible? It is not a blocking issue for me though. |
Codecov Report
@@ Coverage Diff @@
## release/2.x #1391 +/- ##
==============================================
Coverage 88.61% 88.61%
Complexity 2355 2355
==============================================
Files 292 292
Lines 5945 5945
Branches 718 718
==============================================
Hits 5268 5268
Misses 497 497
Partials 180 180Continue to review full report at Codecov.
|
|
Added a test (a bit heavyweight since it needs to be a separate project to avoid influencing others) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to register an extension for automatic use using Java's
ServiceLoadermechanism.https://junit.org/junit5/docs/current/user-guide/#extensions-registration-automatic
Some projects may want to provide their own
META-INFfile to avoid tediously addingMockitoExtensionto tests since it is very common. However,ServiceLoaderrequires the class to have a no-args public constructor, so the current extension cannot be used with theServiceLoadermechanism.Fixes #1390
check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant