Updated test coverage for async verification #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can write specific assertions making the tests stronger. I need this for reworking of 'after' and 'timeout' tests.
- Some existing tests for the feature did not work due to flaws in ReplyRule. Some of the tests (now ignored) consistently failed but succeeded only when used with reply rule. - Some existing tests had weak assertions that did not fully cover the feature. - Suggested simpler and cleaner way of implementing delayed execution via new 'AsyncTesting' class, instead of 'DelayedExecution' Although we are considering deprecating 'after()', we need good coverage for an existing feature even if it will be removed in the long run.
Codecov Report
@@ Coverage Diff @@
## release/2.x #1429 +/- ##
================================================
+ Coverage 88.61% 88.7% +0.08%
- Complexity 2357 2364 +7
================================================
Files 292 293 +1
Lines 5949 5983 +34
Branches 719 733 +14
================================================
+ Hits 5272 5307 +35
- Misses 497 498 +1
+ Partials 180 178 -2
Continue to review full report at Codecov.
|
|
@ChristianSchwarz, any feedback about this change? |
|
I will take a look. |
|
I'll merge this if that's ok. It mostly test code change with a compatible change to exceptions. Happy to take review feedback after it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests with after() verification mode
Although we are considering deprecating 'after()', we need good coverage for an existing feature even if it will be removed in the long run.