Improved sensitivity of potential stubbing problem #1539
Conversation
Codecov Report
@@ Coverage Diff @@
## release/2.x #1539 +/- ##
=================================================
- Coverage 88.58% 88.53% -0.05%
- Complexity 2402 2406 +4
=================================================
Files 299 299
Lines 6044 6053 +9
Branches 734 737 +3
=================================================
+ Hits 5354 5359 +5
- Misses 511 513 +2
- Partials 179 181 +2
Continue to review full report at Codecov.
|
| && s.getInvocation().getMethod().getName().equals(invocation.getMethod().getName()) | ||
| //If stubbing and invocation are in the same source file we assume they are in the test code, | ||
| // and we don't flag it as mismatch: | ||
| && !s.getInvocation().getLocation().getSourceFile().equals(invocation.getLocation().getSourceFile())) { |
There was a problem hiding this comment.
This would not work if the setup is performed in a base class or helper class. Can we figure out a solution for these situations as well?
There was a problem hiding this comment.
This PR is improving the current behavior a lot already. We can always improve it further without blocking this PR. Feel free to suggest a solution!
There was a problem hiding this comment.
@TimvdLippe, thoughts?
There was a problem hiding this comment.
I have not been able to come up with a proper solution, other than using a different stubbing mechanism. I fear that, no matter how hard we try, we will keep on receiving issues on this feature, where users will run into all the edge-cases.
That said, this does improve the current situation, so we can push forward. I just think we have to solve the fundamental problem first to be able to prevent these kind of issues popping up.
There was a problem hiding this comment.
Thank you for review!
TimvdLippe
dismissed
their stale review
This change is an improvement to the status quo.
This change improves the developer experience when stubbing same method with different argument, in the same test class. Example: when(mock.foo(1)).thenReturn(1); when(mock.foo(2)).thenReturn(2); // <- no longer throws PotentialStubbingProblem (false negative) This reduces the number of false negatives reported by strict stubbing.
mockitoguy
force-pushed
the
next-strict-tweak
branch
from
e1d0aea
to
90c89c3
Compare
This change improves the developer experience with strict stubbing. It is now possible to stub the same method with different argument multiple times in the test. Previously, we threw PotentialStubbingProblem exception in this scenario:
This reduces the number of false negatives reported by strict stubbing.
Fixes #1522, #1496, partially #769, #720