Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with leftover state when stubbing with bad throwables #1549

Merged
merged 1 commit into from Dec 2, 2018

Conversation

mockitoguy
Copy link
Member

Fixed issue with leftover state when stubbing with bad throwables. Fixes #1514

When stubbing with bad throwables we were leaving state behind. Fixes #1514
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bric3
Copy link
Contributor

bric3 commented Nov 27, 2018

Good catch

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #1549 into release/2.x will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/2.x    #1549      +/-   ##
=================================================
+ Coverage          88.57%   88.79%   +0.21%     
- Complexity          2406     2539     +133     
=================================================
  Files                299      299              
  Lines               6057     6263     +206     
  Branches             736      763      +27     
=================================================
+ Hits                5365     5561     +196     
- Misses               511      522      +11     
+ Partials             181      180       -1
Impacted Files Coverage Δ Complexity Δ
...ava/org/mockito/internal/stubbing/StubberImpl.java 93.33% <100%> (+6.37%) 20 <0> (+1) ⬆️
...mockito/internal/stubbing/ConsecutiveStubbing.java 90.9% <0%> (-9.1%) 4% <0%> (+2%)
...mockito/internal/stubbing/OngoingStubbingImpl.java 94.11% <0%> (-5.89%) 7% <0%> (+2%)
...va/org/mockito/internal/stubbing/BaseStubbing.java 91.66% <0%> (-2.09%) 30% <0%> (+12%)
...java/org/mockito/internal/exceptions/Reporter.java 93.39% <0%> (-0.29%) 180% <0%> (+90%)
.../internal/junit/DefaultStubbingLookupListener.java 96.55% <0%> (+0.55%) 14% <0%> (+2%) ⬆️
...rc/main/java/org/mockito/internal/MockitoCore.java 98.5% <0%> (+0.61%) 59% <0%> (+22%) ⬆️
...a/org/mockito/internal/debugging/LocationImpl.java 92.3% <0%> (+2.83%) 10% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16271ee...93540e7. Read the comment docs.

@mockitoguy mockitoguy self-assigned this Nov 28, 2018
@mockitoguy mockitoguy merged commit d49c667 into release/2.x Dec 2, 2018
@TimvdLippe TimvdLippe deleted the next-bugfix branch December 12, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants