Remove Workaround for #1444 #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, Travis fails. Must we also update Shipkit? @mockitoguy do you know more about this? |
|
This still requires an update to Shipkit. Closing this for now and hopefully it is fixed soon upstream. |
TWiStErRob
added a commit
to TWiStErRob/mockito
that referenced
this pull request
Jul 4, 2023
…publishToMavenLocal` and println debugging) Here's a little investigation of the history of this block: 20180725 Original issue (mockito 2.20.0): mockito#1444 20180726 Workaround added (mockito 2.20.1): mockito#1446 20180726 Issue that obsoletes the workaround (shipkit 2.0.29): mockito/shipkit#741 20180727 Fix that obsoletes the workaround (shipkit 2.0.30): mockito/shipkit#742 20181221 Attempt at removing ([mockito 2.23.11](https://github.com/mockito/mockito/releases/tag/v2.23.11)): mockito#1575, but shipkit used was still [2.0.28](https://github.com/mockito/mockito/blob/v2.23.11/build.gradle#L14) 20190220 Shipkit version bump that should've removed the workaround (mockito 2.24.6): mockito@866c5d2 (cc @mstachniuk) 20200504 Attempt at removing (mockito 3.3.7): grimreaper@9b4c129 (cc @grimreaper), but PR never raised. 20210116 Shipkit mono-plugin deprecation (shipkit 2.3.5): mockito/shipkit#887 20201028 Shipkit migration (mockito 3.6.1): mockito@7c51297 (cc @mockitoguy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed workaround for #1444.