VerificationCollector to handle non-matching args and other assertions

[kriegfrj]

This fix for #1642 widens the catch in VerificationCollectorImpl so that it will catch any AssertionError, rather than just MockitoAssertionError. In this way, any comparison failures (such as the built-in argument comparison when running under JUnit) will also be collected rather than propagating through to the test framework.

There are also two commits which are more cosmetic improvements to VerificationCollectorImplTest:

• Rename assertAtLeastOneFailure() to assertExactlyOneFailure() (more accurate description of what it does).
• Change Assert.fail() to AssertJ's assertBecauseExceptionWasNotThrown() (produces better diagnostics in the case of a failure).

[codecov-io]

Codecov Report

Merging #1644 into release/2.x will not change coverage.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             release/2.x    #1644   +/-   ##
==============================================
  Coverage          87.38%   87.38%           
  Complexity          2434     2434           
==============================================
  Files                301      301           
  Lines               6271     6271           
  Branches             781      781           
==============================================
  Hits                5480     5480           
  Misses               596      596           
  Partials             195      195

Impacted Files	Coverage Δ	Complexity Δ
...kito/internal/junit/VerificationCollectorImpl.java	97.22% <100%> (ø)	7 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b745b5d...c7d5d8e. Read the comment docs.

[TimvdLippe]

Thanks for the explanation in the issue and the easy fix + great tests!