Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc typo and use HTML list #1695

Merged
merged 1 commit into from May 3, 2019
Merged

Fix javadoc typo and use HTML list #1695

merged 1 commit into from May 3, 2019

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Apr 27, 2019

The javadoc for InvocationOnMock.getArgument(int index, Class<T> clazz); had two typos:

  • "to directly pas the result"
  • "clazz to cast the argument to"

Additionally I changed the list to be a proper HTML list, the current version just collapsed it into one text block: https://static.javadoc.io/org.mockito/mockito-core/2.27.0/org/mockito/invocation/InvocationOnMock.html#getArgument-int-java.lang.Class-

It might also be worth it adding the actual HTML paragraphs into the javadoc (for the other methods as well).

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe
Copy link
Contributor

Travis is failing on unrelated issues. Will take a look next week.

@codecov-io
Copy link

codecov-io commented May 3, 2019

Codecov Report

Merging #1695 into release/2.x will increase coverage by 71.85%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/2.x    #1695       +/-   ##
==================================================
+ Coverage          12.26%   84.12%   +71.85%     
- Complexity           318     2448     +2130     
==================================================
  Files                307      308        +1     
  Lines               6475     6657      +182     
  Branches             811      833       +22     
==================================================
+ Hits                 794     5600     +4806     
+ Misses              5553      860     -4693     
- Partials             128      197       +69
Impacted Files Coverage Δ Complexity Δ
...o/errorprone/bugpatterns/MockitoNotExtensible.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...o/errorprone/bugpatterns/MockitoInternalUsage.java 0% <0%> (ø) 0% <0%> (?)
...al/creation/bytebuddy/SubclassInjectionLoader.java 21.05% <0%> (+2.63%) 4% <0%> (ø) ⬇️
...ain/java/org/mockito/internal/util/Primitives.java 94.44% <0%> (+2.77%) 7% <0%> (+1%) ⬆️
...ito/internal/creation/bytebuddy/ModuleHandler.java 25% <0%> (+4.8%) 2% <0%> (ø) ⬇️
...rg/mockito/internal/invocation/MatchersBinder.java 100% <0%> (+14.28%) 6% <0%> (+1%) ⬆️
...o/internal/creation/settings/CreationSettings.java 100% <0%> (+14.28%) 23% <0%> (+6%) ⬆️
...rg/mockito/internal/matchers/LocalizedMatcher.java 100% <0%> (+16.66%) 3% <0%> (+1%) ⬆️
...internal/configuration/plugins/PluginRegistry.java 100% <0%> (+19.04%) 7% <0%> (+3%) ⬆️
...eation/bytebuddy/TypeCachingBytecodeGenerator.java 75% <0%> (+21.42%) 3% <0%> (+1%) ⬆️
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881e09e...80f5937. Read the comment docs.

@TimvdLippe TimvdLippe merged commit da80724 into mockito:release/2.x May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants