Migrate junitJupiterExtensionTest subproject to kotlin dsl #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/2.x #1704 +/- ##
==============================================
Coverage 86.52% 86.52%
Complexity 2480 2480
==============================================
Files 308 308
Lines 6525 6525
Branches 818 818
==============================================
Hits 5646 5646
Misses 681 681
Partials 198 198Continue to review full report at Codecov.
|
TimvdLippe
approved these changes
May 5, 2019
| val Project.libraries | ||
| get() = rootProject.extra["libraries"] as Map<String, Any> | ||
|
|
||
| fun Project.library(name: String) = |
There was a problem hiding this comment.
Should these functions be declared in dependencies.gradle?
There was a problem hiding this comment.
yes, indeed, we have to move them to a better place. I will do so while migrating the next subproject if that's ok for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #1359.
This pr migrates a very first subproject to kotlin dsl.