Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #1706

Merged
merged 2 commits into from May 6, 2019
Merged

Fix a typo #1706

merged 2 commits into from May 6, 2019

Conversation

vrana
Copy link
Contributor

@vrana vrana commented May 6, 2019

Hey,

Thanks for the contribution, this is awesome.
As you may have read, project members have somehow an opinionated view on what and how should be
Mockito, e.g. we don't want mockito to be a feature bloat.
There may be a thorough review, with feedback -> code change loop.

Which branch :

  • On mockito 2.x, make your pull request target release/2.x
  • On next mockito version make your pull request target master

check list

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #1706 into release/2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/2.x    #1706   +/-   ##
==============================================
  Coverage          86.52%   86.52%           
  Complexity          2480     2480           
==============================================
  Files                308      308           
  Lines               6525     6525           
  Branches             818      818           
==============================================
  Hits                5646     5646           
  Misses               681      681           
  Partials             198      198
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/ArgumentCaptor.java 100% <ø> (ø) 5 <0> (ø) ⬇️
src/main/java/org/mockito/Mockito.java 96.66% <ø> (ø) 41 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237e915...9ff643d. Read the comment docs.

@TimvdLippe TimvdLippe merged commit b6f0fcf into mockito:release/2.x May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants