Fixes #1717 : configure the MethodVisitor for Java 11 compatibility #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #1717. |
Codecov Report
@@ Coverage Diff @@
## release/2.x #1718 +/- ##
=================================================
- Coverage 86.53% 85.67% -0.86%
+ Complexity 2481 2477 -4
=================================================
Files 309 309
Lines 6528 6528
Branches 818 818
=================================================
- Hits 5649 5593 -56
- Misses 681 747 +66
+ Partials 198 188 -10
Continue to review full report at Codecov.
|
fpavageau
force-pushed
the
fix-asm-visitor
branch
from
e2b6138
to
3696ff9
Compare
|
I've added a unit test, thanks to an article written by @raphw, of course. |
|
Could you update the PR to use |
fpavageau
force-pushed
the
fix-asm-visitor
branch
from
3696ff9
to
350067f
Compare
…ility By using Byte Buddy's supported ASM API version, the visitor will always be compatible with the currently supported bytecode, including when using the experimental feature.
fpavageau
force-pushed
the
fix-asm-visitor
branch
from
350067f
to
a626b1c
Compare
|
@raphw done. I've also rebased on |
|
LGTM |
|
I will merge this and publish a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into adding a unit test, if I can find how to use Byte Buddy to generate a class with a Conditional Dynamic instruction when running with Java 11.