Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possible NPE when assumeTrue aborts a test #1725

Closed
wants to merge 1 commit into from

Conversation

daswass
Copy link

@daswass daswass commented Jun 10, 2019

check list

  • [✓] Read the contributing guide
  • [✓] PR should be motivated, i.e. what does it fix, why, and if relevant how
  • [✓] If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • [✓] Avoid other runtime dependencies
  • [✓] Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • [✓] The pull request follows coding style
  • [✓] Mention Fixes #<issue number> in the description if relevant
  • [✓] At least one commit should mention Fixes #<issue number> if relevant

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a regression test for this.

@codecov-io
Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #1725 into release/2.x will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/2.x    #1725      +/-   ##
=================================================
- Coverage          86.53%   86.51%   -0.03%     
  Complexity          2481     2481              
=================================================
  Files                309      309              
  Lines               6528     6531       +3     
  Branches             818      819       +1     
=================================================
+ Hits                5649     5650       +1     
- Misses               681      682       +1     
- Partials             198      199       +1
Impacted Files Coverage Δ Complexity Δ
...va/org/mockito/junit/jupiter/MockitoExtension.java 86.95% <60%> (-3.75%) 13 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3f69d...b36c9d5. Read the comment docs.

@TimvdLippe
Copy link
Contributor

Closing per my review. Please reopen when a regression test is added.

@TimvdLippe TimvdLippe closed this Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants