Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java.lang.StackWalker instead of sun.misc.* #2225

Closed
wants to merge 1 commit into from

Conversation

TimvdLippe
Copy link
Contributor

java.lang.StackWalker is the public API shipped in Java 9. Tentatively opening this PR to see whether the memory improvements are still there.

@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #2225 (e36cb84) into release/3.x (ea6d7ad) will decrease coverage by 2.92%.
The diff coverage is 11.42%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #2225      +/-   ##
=================================================
- Coverage          84.64%   81.71%   -2.93%     
+ Complexity          2726     2694      -32     
=================================================
  Files                326      326              
  Lines               8315     8324       +9     
  Branches             990      988       -2     
=================================================
- Hits                7038     6802     -236     
- Misses              1006     1261     +255     
+ Partials             271      261      -10     
Impacted Files Coverage Δ Complexity Δ
...ternal/exceptions/stacktrace/StackTraceFilter.java 32.69% <11.42%> (-48.27%) 8.00 <3.00> (-2.00)
...util/reflection/InstrumentationMemberAccessor.java 11.50% <0.00%> (-75.00%) 1.00% <0.00%> (-24.00%)
...al/creation/bytebuddy/SubclassInjectionLoader.java 25.53% <0.00%> (-31.92%) 4.00% <0.00%> (-2.00%)
...ito/internal/creation/bytebuddy/ModuleHandler.java 6.71% <0.00%> (-16.11%) 2.00% <0.00%> (ø%)
...al/creation/bytebuddy/InlineBytecodeGenerator.java 72.92% <0.00%> (-11.36%) 35.00% <0.00%> (-3.00%)
...internal/util/reflection/ModuleMemberAccessor.java 81.81% <0.00%> (-9.10%) 6.00% <0.00%> (ø%)
...l/creation/bytebuddy/InlineByteBuddyMockMaker.java 66.85% <0.00%> (-0.58%) 48.00% <0.00%> (-1.00%)
...va/org/mockito/junit/jupiter/MockitoExtension.java 89.47% <0.00%> (-0.27%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6d7ad...e36cb84. Read the comment docs.

@TimvdLippe
Copy link
Contributor Author

I didn't get to this and the memory test has been disabled (#2478). Let's revisit this as part of resolving #2478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants