Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI on Android API level 33 for Java 11 compatibility testing #2899

Merged
merged 3 commits into from
Feb 4, 2023
Merged

CI on Android API level 33 for Java 11 compatibility testing #2899

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
986d849
Fix redundant space
TWiStErRob Feb 3, 2023
ca926c4
Remove Java from the matrix, it's not relevant for Android.
TWiStErRob Feb 3, 2023
19059e6
Add 33 and explicitly list all the combinations
TWiStErRob Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 12 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
if: matrix.java == 11 && matrix.entry.mock-maker == 'mock-maker-default' # SINGLE-MATRIX-JOB
run: ./gradlew spotlessCheck

- name: 6. Build on Java ${{ matrix.java }} with ${{ matrix.entry.mock-maker }} and ${{ matrix.entry.member-accessor }}
- name: 6. Build on Java ${{ matrix.java }} with ${{ matrix.entry.mock-maker }} and ${{ matrix.entry.member-accessor }}
run: ./gradlew build idea --scan
env:
MOCK_MAKER: ${{ matrix.entry.mock-maker }}
Expand Down Expand Up @@ -95,8 +95,13 @@ jobs:
# Definition of the build matrix
strategy:
matrix:
java: [ 11 ]
android-api: [ 26 ]
include:
# Minimum supported
- android-api: 26
android-image-type: default
# Maximum available
- android-api: 33
android-image-type: google_apis
Comment on lines +98 to +104
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting idea: https://github.com/google/accompanist/blob/d1e347560bc9c269a4bc4ed398f40ab6f613d78b/.github/workflows/device-tests.yml#L51-L62

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better https://github.com/tinylog-org/tinylog/blob/v3.0/.github/workflows/build.yaml#L104


# All build steps
steps:
Expand All @@ -105,17 +110,18 @@ jobs:
with:
fetch-depth: '0' # https://github.com/shipkit/shipkit-changelog#fetch-depth-on-ci

- name: 2. Set up Java ${{ matrix.java }}
- name: 2. Set up Java 11
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: ${{ matrix.java }}
java-version: 11

- name: 3. Run Android tests on Java ${{ matrix.java }} with Android API level ${{ matrix.android-api }}
- name: 3. Run Android tests on Android API level ${{ matrix.android-api }}
uses: reactivecircus/android-emulator-runner@v2
with:
arch: x86_64
api-level: ${{ matrix.android-api }}
target: ${{ matrix.android-image-type }}
script: ./gradlew :androidTest:connectedCheck --no-daemon --no-build-cache

#
Expand Down