Fixes 2947: correct visibility check to respect nestmates #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphw
force-pushed
the
visibility-check-nestmates
branch
2 times, most recently
from
0e2890c
to
50457b3
Compare
…asses can invoke private constructors if they are nested classes.
raphw
force-pushed
the
visibility-check-nestmates
branch
from
50457b3
to
90de7e6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2948 +/- ##
============================================
+ Coverage 85.68% 85.70% +0.02%
- Complexity 2864 2865 +1
============================================
Files 325 325
Lines 8696 8696
Branches 1074 1074
============================================
+ Hits 7451 7453 +2
+ Misses 967 966 -1
+ Partials 278 277 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Java 11, subclasses can invoke private constructors if they are nested classes and the access right is registered in the nestmate property of both classes. Without recognizing such rights, Mockito cannot create a synthetic constructor hierarchy that sets fields for spies as the constructor generation is skipped due to a missing super constructor that is considered valid.