New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Javadoc for ArgumentCaptor #3103
Update Javadoc for ArgumentCaptor #3103
Conversation
Hey all, recently updated a project to use 5.5.0. Had to go through and adjust a lot of the tests, as my times() calls were causing tests to fail. I was looking at the javadoc to see if there were changes, but it wasn't until I took a diff of the 4.7.0 and 5.5.0 tags that I could see org.mockito.internal.matchers.CapturingMatcher#matches had a behavior change. I see it was mentioned in the release notes here, but would have been useful to be in the javadoc. |
f6ddd2c
to
3dd4bd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small nits, other than that LGTM!
…nsider the generic type.
99f0064
to
617b3bc
Compare
Updated with your suggestions. Commits squashed. Thank you @TimvdLippe! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
============================================
+ Coverage 85.45% 85.48% +0.02%
- Complexity 2889 2892 +3
============================================
Files 329 329
Lines 8822 8826 +4
Branches 1095 1095
============================================
+ Hits 7539 7545 +6
+ Misses 995 994 -1
+ Partials 288 287 -1
☔ View full report in Codecov by Sentry. |
Update Javadoc for ArgumentCaptor to indicate that the captor will match based on the generic type since Mockito 5.0
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant