Use spdx identifier for license name #3134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello mocki-devs 馃憢
in our company we just added licensee to our code base to make sure we are only using dependencies with licenses we agree on.
Behind the scense, the plugin scan the POM file and check the license name.
The plugin allow only license names that are part of the SPDX Specification.
For whatever reasons, we can't add any arbitrary license names to it, without adding the license URL.
This means, adding the license name
The MIT License
(what you are currently use) without adding the license URL (https://github.com/mockito/mockito/blob/main/LICENSE) is not working. It will fail with an error message.Because mockito uses the default MIT License without any modification I guess it make sense to align this and use the SPDX Identifier, which is just
MIT
.If we use this, the plugin will not fail anymore. Because it detects the official SPDX Identifier and is there "sure" that this is a valid license.
Honestly, I'm not sure you want this change. 馃榿
So feel free to close it and just go with the current license name you have been using for years.
On the other hand, why not stick to an official specification? Shouldn't hurt anyway, right? 馃し
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant