Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spdx identifier for license name #3134

Merged
merged 1 commit into from Oct 6, 2023
Merged

Conversation

StefMa
Copy link
Contributor

@StefMa StefMa commented Oct 6, 2023

Hello mocki-devs 馃憢

in our company we just added licensee to our code base to make sure we are only using dependencies with licenses we agree on.

Behind the scense, the plugin scan the POM file and check the license name.
The plugin allow only license names that are part of the SPDX Specification.
For whatever reasons, we can't add any arbitrary license names to it, without adding the license URL.
This means, adding the license name The MIT License (what you are currently use) without adding the license URL (https://github.com/mockito/mockito/blob/main/LICENSE) is not working. It will fail with an error message.

Because mockito uses the default MIT License without any modification I guess it make sense to align this and use the SPDX Identifier, which is just MIT.

If we use this, the plugin will not fail anymore. Because it detects the official SPDX Identifier and is there "sure" that this is a valid license.

Honestly, I'm not sure you want this change. 馃榿
So feel free to close it and just go with the current license name you have been using for years.
On the other hand, why not stick to an official specification? Shouldn't hurt anyway, right? 馃し

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@TimvdLippe
Copy link
Contributor

Makes sense, thanks for the fix!

@TimvdLippe TimvdLippe merged commit 597e902 into mockito:main Oct 6, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants