New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to JaCoCo 0.8.11
#3147
Migrate to JaCoCo 0.8.11
#3147
Conversation
Not sure why a bump of Jacoco would start failing these tests. It might be that they have always been flaky and that they rely on ordering. Do you mind debugging locally what is going on here and if you can reproduce the same issues with the same Jacoco version, but with different ordering? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
============================================
- Coverage 85.52% 85.50% -0.02%
Complexity 2912 2912
============================================
Files 333 333
Lines 8856 8858 +2
Branches 1095 1096 +1
============================================
Hits 7574 7574
- Misses 994 995 +1
- Partials 288 289 +1
☔ View full report in Codecov by Sentry. |
56b47c0
to
d74808b
Compare
@TimvdLippe the root cause of failures is this change in JaCoCo: jacoco/jacoco@b865890. org.mockito.internal.util.reflection.ReflectionMemberAccessor#silentSetAccessible doesn't work without JVM flags opening packages (on Java 17). So my question is: what should strategy be around this problem? is it ok to add flags for unit tests or is there any other global solution required? |
@raphw I think adding these flags for our tests is okay, but what do you think? |
I think so, yes. I'd go for it. |
d74808b
to
bfe8752
Compare
CI is green, one job fails at Codecov upload:
|
Bump JaCoCo to fix compatibility with the latest Java versions: https://github.com/jacoco/jacoco/releases
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant