Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Termux in InlineDelegateByteBuddyMockMaker.java #3158

Merged
merged 2 commits into from Oct 24, 2023
Merged

Handle Termux in InlineDelegateByteBuddyMockMaker.java #3158

merged 2 commits into from Oct 24, 2023

Commits on Oct 24, 2023

  1. Handle Termux in InlineDelegateByteBuddyMockMaker.java 

    Termux on Android can run any JVM, so we cannot rely on the vendor
here to determine if we are in Termux. Nonetheless, ByteBuddy can fail to instrument correctly
on this platform, so it is worth showing a meaninful
error message in this scenario.
    @ascopes
    ascopes committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d8cb1ef View commit details
    Browse the repository at this point in the history

  2. Enable testing platform conditions 

    - Implement unit tests for the ByteBuddy platform conditions
- Extract the ByteBuddy platform conditions to a separate utility class
  to enable unit testing them separately. This also enables adding additional
  checks in the future without making the InlineDelegateByteBuddyMockMaker
  much more complicated.
- Added dependency at test time for junit-jupiter-params to enable writing
  parameterized unit tests.
    @ascopes
    ascopes committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    41df2d3 View commit details
    Browse the repository at this point in the history