Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better typing for PluginLoader#loadPlugin(..) #3242

Merged
merged 1 commit into from Jan 23, 2024

Conversation

andrebrait
Copy link
Contributor

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

- Follow up to mockito#3220
- Make the method return the lowest common denominator type
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9173522) 85.33% compared to head (85a74d1) 85.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3242   +/-   ##
=========================================
  Coverage     85.33%   85.33%           
  Complexity     2923     2923           
=========================================
  Files           336      336           
  Lines          8905     8906    +1     
  Branches       1108     1108           
=========================================
+ Hits           7599     7600    +1     
  Misses         1013     1013           
  Partials        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimvdLippe
Copy link
Contributor

Nice, thank you!

@TimvdLippe TimvdLippe merged commit ef3dc8f into mockito:main Jan 23, 2024
18 checks passed
@andrebrait andrebrait deleted the plugin-loader-typing branch January 23, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants