New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3240 : Renamed mockito bom artifact #3251
Conversation
subprojects/bom/bom.gradle
Outdated
@@ -15,7 +15,7 @@ dependencies { | |||
api(project.rootProject) | |||
project.rootProject.subprojects.forEach { subproject -> | |||
if (!subproject.name.endsWith("Test") && | |||
!subproject.name.endsWith("-test") && | |||
!subproject.name.endsWith("java21-test") && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module name needs to change, not the logic, so that the exclusion catches the non-published test module and does NOT publish it in the BOM.
Rename java21 to java21-test in settings.gradle and folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll make the required changes.
Tip: I think you can test this with |
I'll let @TimvdLippe take it from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
=========================================
Coverage 85.33% 85.33%
Complexity 2923 2923
=========================================
Files 336 336
Lines 8906 8906
Branches 1108 1108
=========================================
Hits 7600 7600
Misses 1013 1013
Partials 293 293 ☔ View full report in Codecov by Sentry. |
Description
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>
in the description if relevantFixes #<issue number>
if relevant