Refactored mock cache to be non-blocking. #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.64%
|
raphw
force-pushed
the
non-blocking-cache
branch
from
cd210cc
to
330e8e9
Compare
| generator = avoidingClassLeakageCache.putIfAbsent(new WeakKey<ClassLoader>(classLoader, this), newGenerator = new CachedBytecodeGenerator(mockBytecodeGenerator, weak)); | ||
| if (generator == null) { | ||
| generator = newGenerator; | ||
| } |
There was a problem hiding this comment.
I'd change that code to one variable declaration per line. And I would avoid inline assignment too (the first newGenerator is not needed before the if).
Those too may confuse most readers.
raphw
force-pushed
the
non-blocking-cache
branch
from
330e8e9
to
0ff47d4
Compare
| return (Class<T>) generatedMockClass; | ||
| } finally { | ||
| avoidingClassLeakCacheLock.unlock(); | ||
| void pollAndClearReferences() { |
There was a problem hiding this comment.
I would like a comment on this, or maybe rename it better (I'm thinking loudly).
Not everyone knows ReferenceQueue or how it works, and thus why we need to invoke this method upon get(...).
Ideas welcome.
|
Looks good codewise. |
raphw
force-pushed
the
non-blocking-cache
branch
from
0ff47d4
to
2cb54f2
Compare
raphw
force-pushed
the
non-blocking-cache
branch
from
2cb54f2
to
fabed34
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous cache used a lock to unify concurrency and weak references. Instead, keys are now explicitly wrapped using weak references and similarly to the functioning of a weak hash map, the entries are polled upon accessing the cache. This avoids blocking.