Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls coverage tracking tool allows Mockito source code preview #62

Merged
merged 1 commit into from Jul 21, 2014

Conversation

szpak
Copy link
Member

@szpak szpak commented Jul 13, 2014

Workaround for an issue with Cobertura plugin:
stevesaliman/gradle-cobertura-plugin#53

@szpak
Copy link
Member Author

szpak commented Jul 13, 2014

I don't know why a lot of tests fail after Cobertura instrumentation, e.g.:

org.mockitousage.junitrunner.JUnit44RunnerTest > shouldInitMocksUsingRunner FAILED
java.lang.NoClassDefFoundError at JUnit44RunnerTest.java:32

https://travis-ci.org/mockito/mockito/builds/29847417#L3005

Changes in Coveralls plugin should not affect Cobertura which runs earlier.

@szpak
Copy link
Member Author

szpak commented Jul 13, 2014

The same code works fine i.e. in https://travis-ci.org/mockito/mockito/builds/29848158

@bric3
Copy link
Contributor

bric3 commented Jul 14, 2014

Could this be due to cobertura plugin itself? Does your branch starts from the latest commit in master?

@szpak
Copy link
Member Author

szpak commented Jul 14, 2014

Yes, see fork network. I even reverted Cobertura plugin version to the original version. I suspect it could be some issue with Travis. The same code (in different branch) builds fine - https://travis-ci.org/mockito/mockito/builds/29848158 (sometimes...).

Ok, I found out that the problem isn't new, to mention just a few:
https://travis-ci.org/mockito/mockito/builds/29459350#L303
https://travis-ci.org/mockito/mockito/builds/23380870#L510
https://travis-ci.org/mockito/mockito/builds/20497270#L487
https://travis-ci.org/mockito/mockito/builds/15848950#L485
https://travis-ci.org/mockito/mockito/builds/13903736#L482 - the first failure I have found (build 10) - but probably even much older Mockito code would (sometimes) fail on Travis.

Just because it is an after_success task it doesn't fail the whole build.

@szpak
Copy link
Member Author

szpak commented Jul 18, 2014

The problem with Travis has to be resolved anyway, but I think it is safe to merge this PR to improve coveralls reports.

bric3 added a commit that referenced this pull request Jul 21, 2014
Make source code preview available in Coveralls 2
@bric3 bric3 merged commit 00d90fc into mockito:master Jul 21, 2014
@bric3
Copy link
Contributor

bric3 commented Jul 21, 2014

Yeah agreed. Merged.

@szpak szpak deleted the topic/coverallSourceCode2 branch July 21, 2014 08:49
@mockitoguy mockitoguy changed the title Make source code preview available in Coveralls 2 Coveralls coverage tracking tool allows Mockito source code preview Aug 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants