Release procedure for branches and some javadoc #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensured it is possible to release from release branches.
v2.1.0-beta.121 is in bintray/central but does not have docs / release notes due to this bug After 2.1.0 is out I will overhaul the release logic and make it perfect :D
Otherwise I was confused with bintrayUpload task behavior.
I found an idea to test the release without spoling the release/2.x branch
Testing the release logic is hard. We need to make it easier!
- removed 2.0 version - small change that allows me to test releasing from release/test branch
- removed 2.0 version, added TODO for tomorrow - small change that allows me to test releasing from release/test branch
(release process tweaking)
…uild 1348 [ci skip-release]
Ensured it is possible to release from release branches.
v2.1.0-beta.121 is in bintray/central but does not have docs / release notes due to this bug After 2.1.0 is out I will overhaul the release logic and make it perfect :D
Otherwise I was confused with bintrayUpload task behavior.
I found an idea to test the release without spoling the release/2.x branch
- removed 2.0 version - small change that allows me to test releasing from release/test branch
- removed 2.0 version, added TODO for tomorrow - small change that allows me to test releasing from release/test branch
…uild 1348 [ci skip-release]
v2.1.0-beta.121 is in bintray/central but does not have docs / release notes due to this bug After 2.1.0 is out I will overhaul the release logic and make it perfect :D
Otherwise I was confused with bintrayUpload task behavior.
I found an idea to test the release without spoling the release/2.x branch
…e/test Conflicts: doc/release-notes/official.md
Current coverage is 88.24% (diff: 100%)@@ master #627 diff @@
==========================================
Files 266 266
Lines 5163 5163
Methods 0 0
Messages 0 0
Branches 847 847
==========================================
- Hits 4557 4556 -1
Misses 429 429
- Partials 177 178 +1
|
|
LGTM |
@szczepiq I try to avoid merges outside of merging feature branch. You may be interested by
|
|
Thanks @bric3, I'll check this strategy next time I'm in branching trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the amount of commits. It happened due to merging. Please squash when applying the change.
Fixes #594 - now it should be possible to release from branches. It worked for the release/test branch so it should work for release/2.x :)