Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move older releases to separate section #675

Merged
merged 3 commits into from Oct 8, 2016
Merged

Conversation

TimvdLippe
Copy link
Contributor

To prevent any confusion and make it clearer 2.x is now the version developed.

@codecov-io
Copy link

codecov-io commented Oct 5, 2016

Current coverage is 87.23% (diff: 100%)

Merging #675 into master will increase coverage by 0.01%

@@             master       #675   diff @@
==========================================
  Files           272        272          
  Lines          5476       5476          
  Methods           0          0          
  Messages          0          0          
  Branches        901        901          
==========================================
+ Hits           4776       4777     +1   
  Misses          508        508          
+ Partials        192        191     -1   

Powered by Codecov. Last update adc1427...8768df5

![latest 1.x](https://img.shields.io/badge/latest stable-1.x =>-yellow.svg) [ ![latest stable 1.x on bintray](https://img.shields.io/badge/Download-1.10.19-blue.svg)](https://bintray.com/mockito/maven/mockito/1.10.19/view) [ ![latest stable 1.x on maven central](https://img.shields.io/badge/maven%20central-1.10.19-blue.svg)](http://search.maven.org/#artifactdetails|org.mockito|mockito-core|1.10.19|)

![latest 2.x](https://img.shields.io/badge/latest beta-2.x =>-yellow.svg) [ ![Current release](https://api.bintray.com/packages/mockito/maven/mockito/images/download.svg) ](https://bintray.com/mockito/maven/mockito/_latestVersion) [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core/badge.svg?style=flat)](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core)
![latest 2.x](https://img.shields.io/badge/latest 2.x =>-yellow.svg) [ ![Current release](https://api.bintray.com/packages/mockito/maven/mockito/images/download.svg) ](https://bintray.com/mockito/maven/mockito/_latestVersion) [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core/badge.svg?style=flat)](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core)
Copy link
Contributor

@bric3 bric3 Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is wrong see the rich diff.

Replace by https://img.shields.io/badge/latest-2.x =>-yellow.svg
The badge has the following structure separated by a dash : dark text-colored text-color.svg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops should be fixed

![latest 1.x](https://img.shields.io/badge/latest stable-1.x =>-yellow.svg) [ ![latest stable 1.x on bintray](https://img.shields.io/badge/Download-1.10.19-blue.svg)](https://bintray.com/mockito/maven/mockito/1.10.19/view) [ ![latest stable 1.x on maven central](https://img.shields.io/badge/maven%20central-1.10.19-blue.svg)](http://search.maven.org/#artifactdetails|org.mockito|mockito-core|1.10.19|)

![latest 2.x](https://img.shields.io/badge/latest beta-2.x =>-yellow.svg) [ ![Current release](https://api.bintray.com/packages/mockito/maven/mockito/images/download.svg) ](https://bintray.com/mockito/maven/mockito/_latestVersion) [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core/badge.svg?style=flat)](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core)
![latest 2.x](https://img.shields.io/badge/latest-2.x =>-yellow.svg) [ ![Current release](https://api.bintray.com/packages/mockito/maven/mockito/images/download.svg) ](https://bintray.com/mockito/maven/mockito/_latestVersion) [![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core/badge.svg?style=flat)](https://maven-badges.herokuapp.com/maven-central/org.mockito/mockito-core)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could point directly 2.1.0 in Maven Central (to no confuse people with 2.2.0-beta.1)?

As a drawback we would need to switch it manually when 2.2.0 is released.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a bad idea !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is a bit weird, but it should be just fine 😄

@szpak szpak added the docs label Oct 5, 2016
@szpak
Copy link
Member

szpak commented Oct 5, 2016

Please remember also about the 2.x branch.

@bric3
Copy link
Contributor

bric3 commented Oct 6, 2016

I think that our build script can perform the readme update at some point.

@bric3
Copy link
Contributor

bric3 commented Oct 6, 2016

LGTM

@szpak
Copy link
Member

szpak commented Oct 8, 2016

@TimvdLippe Are you still working on this or it can be merged?

@TimvdLippe
Copy link
Contributor Author

I actually someone else was merging since this is my own PR. I generally do not merge my own PRs. Shall I anyways?

@bric3
Copy link
Contributor

bric3 commented Oct 8, 2016

Go on we approved your changes.

@TimvdLippe TimvdLippe merged commit d85b43f into master Oct 8, 2016
@TimvdLippe TimvdLippe deleted the TimvdLippe-patch-1 branch October 8, 2016 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants