Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated way of documenting package by package-info.java #745

Merged
merged 1 commit into from Nov 7, 2016
Merged

Removes deprecated way of documenting package by package-info.java #745

merged 1 commit into from Nov 7, 2016

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Nov 7, 2016

Should fix #665

Nothing to say really, but it has to be done at some point. The most important selling point is that it may allow to annotate a package.

TimvdLippe
TimvdLippe approved these changes Nov 7, 2016
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good statically. Will have to generate javadocs to have full confirmation, but I suppose that's not a problem.

@bric3
Copy link
Contributor Author

bric3 commented Nov 7, 2016

Thanks @TimvdLippe I believe this is OK javadoc wise

@TimvdLippe
Copy link
Contributor

I trust you then 😄

@TimvdLippe TimvdLippe merged commit f0fdf8f into release/2.x Nov 7, 2016
@TimvdLippe TimvdLippe deleted the removes-packagehtml branch November 7, 2016 22:55
@bric3
Copy link
Contributor Author

bric3 commented Nov 7, 2016

Around midnight? 😛

@mockitoguy
Copy link
Member

Nice change, thanks for keeping the codebase clean!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use package-info.java instead of the old html file
3 participants
@bric3 @TimvdLippe @mockitoguy