Test clean up according to discussions for RememberingListeners #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 86.67% (diff: 100%)
@@ release/2.x #831 diff @@
=============================================
Files 284 284
Lines 5666 5666
Methods 0 0
Messages 0 0
Branches 924 924
=============================================
Hits 4911 4911
Misses 563 563
Partials 192 192
|
kobbikobb
changed the title
|
@bric3 @TimvdLippe Sorry for this new PR with the same code. Previously we were discussing #825. In an attempt to fix the PR github lost the link and I couldn't reconnect it. This PR is building and has only one commit message and no merge... |
|
Looks good to me. Thanks for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue @719 we wanted to clean up the tests for RememberingListeners.
The tests should follow the same style and conventions.
Set up should not contain variables used by all the tests.
We previously had another PR for this in #825. That build was failing for some reason not obvious and had 1 merge commit that we wanted to remove. In an attempt to rebase and reset the history github lost the connection to the remote fork. Instead of spending time investigating I just created a new PR.