Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Support for GitHub Enterprise #61

Closed
mstachniuk opened this issue Apr 3, 2017 · 3 comments
Closed

Support for GitHub Enterprise #61

mstachniuk opened this issue Apr 3, 2017 · 3 comments

Comments

@mstachniuk
Copy link
Contributor

mstachniuk commented Apr 3, 2017

Problem

Currently mockito-release-tools works only with github.com. A path to it is hardcoded in the code :(. This project needs to works with GitHub Enterprise API otherwise it cannot be used in enterprise setting. A property to configure GitHub Enterprise needs to optional and by default it should works with github.com.

Suggested implementation

ReleaseConfiguration.GitHub should have an optional setting for the url base host:

releasing {
    github.apiUrl = "https://github.in.your.company.com/api/v3"
    github.url = "https://github.in.your.company.com"
}
@mockitoguy
Copy link
Member

@mstachniuk, can you confirm suggested implementation above?

@mstachniuk
Copy link
Contributor Author

mstachniuk commented Apr 23, 2017

I suggest to add 2 options to the configuration:

releasing {
    github.apiUrl = "https://github.in.your.company.com/api/v3"
    github.url = "https://github.in.your.company.com"
    // others ...
}

The first one to the API endpoint for generation API requests and second one for generating links for developers in pom (see: PomCustomizer.groovy)

@mockitoguy
Copy link
Member

Nice proposal! I updated "api" -> "apiUrl". Let's make sure they are defaulted so that we don't have to configure it for typical OS builds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants