- disable stack on verify

mockk · Apr 19, 2020 · 1ff44ee · 1ff44ee
1 parent 4e65812
commit 1ff44ee
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -1037,6 +1037,7 @@ How to use:
 relaxed=true|false
 relaxUnitFun=true|false
 recordPrivateCalls=true|false
+stackTracesOnVerify=true|false
 ```
 
 ## DSL tables

diff --git a/dsl/common/src/main/kotlin/io/mockk/MockKSettings.kt b/dsl/common/src/main/kotlin/io/mockk/MockKSettings.kt
@@ -6,4 +6,6 @@ expect object MockKSettings {
     val relaxUnitFun: Boolean
 
     val recordPrivateCalls: Boolean
+
+    val stackTracesOnVerify: Boolean
 }
diff --git a/dsl/js/src/main/kotlin/io/mockk/MockKSettings.kt b/dsl/js/src/main/kotlin/io/mockk/MockKSettings.kt
@@ -9,4 +9,7 @@ actual object MockKSettings {
 
     actual val recordPrivateCalls: Boolean
         get() = js("global.io_mockk_settings_recordPrivateCalls || false") as Boolean
+
+    actual val stackTracesOnVerify: Boolean
+        get() = js("global.io_mockk_settings_stackTracesOnVerify || false") as Boolean
 }
diff --git a/dsl/jvm/src/main/kotlin/io/mockk/MockKSettings.kt b/dsl/jvm/src/main/kotlin/io/mockk/MockKSettings.kt
@@ -27,6 +27,9 @@ actual object MockKSettings {
     actual val recordPrivateCalls: Boolean
         get() = booleanProperty("recordPrivateCalls", "false")
 
+    actual val stackTracesOnVerify: Boolean
+        get() = booleanProperty("stackTracesOnVerify", "true")
+
 
     fun setRelaxed(value: Boolean) {
         properties.setProperty("relaxed", value.toString());

diff --git a/mockk/common/src/main/kotlin/io/mockk/impl/verify/UnorderedCallVerifier.kt b/mockk/common/src/main/kotlin/io/mockk/impl/verify/UnorderedCallVerifier.kt
@@ -4,6 +4,7 @@ import io.mockk.InternalPlatformDsl.toStr
 import io.mockk.Invocation
 import io.mockk.InvocationMatcher
 import io.mockk.MockKGateway.*
+import io.mockk.MockKSettings
 import io.mockk.RecordedCall
 import io.mockk.impl.InternalPlatform
 import io.mockk.impl.Ref
@@ -58,8 +59,11 @@ open class UnorderedCallVerifier(
                     "$callIdxMsg should not be called" +
                             "\n\nCalls:\n" +
                             formatCalls(allCallsForMockMethod) +
-                            "\n\nStack traces:\n" +
-                            stackTraces(allCallsForMockMethod)
+                            "\n" +
+                            if (MockKSettings.stackTracesOnVerify)
+                                "\n\nStack traces:\n" + stackTraces(allCallsForMockMethod)
+                            else
+                                ""
                 )
             }
         } else when (allCallsForMockMethod.size) {
@@ -73,8 +77,11 @@ open class UnorderedCallVerifier(
                         "$callIdxMsg was not called." +
                                 "\n\nCalls to same mock:\n" +
                                 formatCalls(allCallsForMock) +
-                                "\n\nStack traces:\n" +
-                                stackTraces(allCallsForMock)
+                                "\n" +
+                                if (MockKSettings.stackTracesOnVerify)
+                                    "\n\nStack traces:\n" + stackTraces(allCallsForMock)
+                                else
+                                    ""
                     })
                 }
             }
@@ -113,17 +120,23 @@ open class UnorderedCallVerifier(
                                 "$callIdxMsg. No matching calls found." +
                                         "\n\nCalls to same method:\n" +
                                         formatCalls(allCallsForMockMethod) +
-                                        "\n\nStack traces:\n" +
-                                        stackTraces(allCallsForMockMethod)
+                                        "\n" +
+                                        if (MockKSettings.stackTracesOnVerify)
+                                            "\n\nStack traces:\n" + stackTraces(allCallsForMockMethod)
+                                        else
+                                            ""
                             })
                     } else {
                         VerificationResult.Failure(
                             "$callIdxMsg. $n matching calls found, " +
                                     "but needs at least $min${atMostMsg(max)} calls" +
                                     "\nCalls:\n" +
                                     formatCalls(allCallsForMock) +
-                                    "\n\nStack traces:\n" +
-                                    stackTraces(allCallsForMock)
+                                    "\n" +
+                                    if (MockKSettings.stackTracesOnVerify)
+                                        "\n\nStack traces:\n" + stackTraces(allCallsForMock)
+                                    else
+                                        ""
                         )
                     }
                 }

diff --git a/mockk/common/src/main/kotlin/io/mockk/impl/verify/VerificationHelpers.kt b/mockk/common/src/main/kotlin/io/mockk/impl/verify/VerificationHelpers.kt
@@ -1,6 +1,7 @@
 package io.mockk.impl.verify
 
 import io.mockk.Invocation
+import io.mockk.MockKSettings
 import io.mockk.RecordedCall
 import io.mockk.StackElement
 import io.mockk.impl.InternalPlatform
@@ -56,8 +57,11 @@ object VerificationHelpers {
         return "\n\nMatchers: \n" + calls.map { it.matcher.toString() }.joinToString("\n") +
                 "\n\nCalls:\n" +
                 formatCalls(allCalls) +
-                "\n\nStack traces:\n" +
-                stackTraces(allCalls)
+                "\n" +
+                if (MockKSettings.stackTracesOnVerify)
+                    "\nStack traces:\n" + stackTraces(allCalls)
+                else
+                    ""
     }
 }