Fix InstantiationError when using any() where a sealed type is expected #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffred
force-pushed
the
sealed-any
branch
2 times, most recently
from
064bb80
to
356001a
Compare
josepanguera
approved these changes
Oct 3, 2022
|
Thanks for looking into this. Can you also add test coverage, please? 🙏 |
|
Done, @diastremskii already added tests for this is in his PR #937, I've merged that commit into my branch. |
|
Sorry for missing this in my PR! |
|
Are the failing test with java 19 what is holding back this PR? |
|
I guess it would help to rebase the PR onto the current master branch, as it uses Java 18 instead of 19 in the CI matrix |
|
Rebased it |
|
@Raibaz thanks for merging! Are you planning to release a new version anytime soon? |
|
Any release plan about this PR? |
|
Would really appreciate a release, now that Spring Boot 3.0.0 is GA, and targets Java 17, this is becoming a blocker for a migration. |
|
You're right, just released v1.13.3: https://github.com/mockk/mockk/releases/tag/1.13.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934
There's no specific test for the issue, that is part of this pr: #937