Rules' AND operator with empty rules always intercept the request

[255kb]

Describe the bug
Having empty rules with "AND" operator serves the corresponding response even if another response's rules match

To Reproduce

• create 2 responses
• set the first response's rules to AND, and remove all rules
• add one rule on the second one
• make a call that matches the second response, you get the first one

bug#6.zip

Expected behavior
We should get the second one

Mockoon version:
all

OS / OS version:
all

[mauriceackel]

The error is this line

The problem is that Array.every returns true if the input array is empty.
Potential fix:

let response = this.routeResponses.find((routeResponse) => {
  if (routeResponse.rules.length === 0) {
    return false;
  }

  return routeResponse.rulesOperator === 'AND'
    ? routeResponse.rules.every(this.isValidRule)
    : routeResponse.rules.some(this.isValidRule);
});

Notice, that I also changed !!routeResponse.rules.find(this.isValidRule) to routeResponse.rules.some(this.isValidRule) and removed the unnecessary double negation at routeResponse.rules.every(this.isValidRule).

@255kb Can you double-checkt that this logic in fact behaves like the current one? Especially w.r.t. the early return/the if statement.

[255kb]

Thanks @mauriceackel your fix is indeed working!