This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Fix bug trailing slash to the prefix #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #422
255kb
approved these changes
Apr 19, 2021
mauriceackel
reviewed
May 7, 2021
| let routePath = `/${ | ||
| this.environment.endpointPrefix | ||
| }/${declaredRoute.endpoint.replace(/ /g, '%20')}`; | ||
| routePath = routePath.replace('//', ''); |
There was a problem hiding this comment.
@255kb I think this should be
routePath = routePath.replace('//', '/')
Otherwise, double slashes get completely removed. Apart from that, I think this is not the best solution as it would not solve cases where there are tripple slashes and especially, it only replaces the first occurrence of a double slash and not all.
I suggest the following:
routePath = routePath.replace(/\/\/+/g, '/');
There was a problem hiding this comment.
True for the triple slashes, but the replace was fixed after the PR merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
Parent issue
mockoon/mockoon#422
Closes #422
Technical implementation details