This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Add baseUrl Request Helper #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiealmeda
commented
May 6, 2021
|
Hmmm.. lints are failing, I'll check tomorrow. |
|
Yes, you need to use prettier for formatting, it's mandatory. Easiest is to use the VSCode/Webstorm extension, but you could also do a |
255kb
suggested changes
May 7, 2021
There was a problem hiding this comment.
Thanks for the PR, it looks great 👍
Maybe my idea of allowing null for the environment wasn't that good, we should use {} as any in the tests, so we don't have to allow Environment | null in the TemplateParser just for them. Could you please make the changes?
Sorry for the extra work.
louiealmeda
force-pushed
the
feature/7-add-baseUrl-request-helper
branch
from
518464e
to
e548eea
Compare
|
Thanks for the feedback and tips @255kb, ready for another review 👍 |
255kb
suggested changes
May 7, 2021
….com/louiealmeda/commons-server into feature/7-add-baseUrl-request-helper
255kb
approved these changes
May 7, 2021
|
Thanks! I will take care of the documentation and integrate the lib in the next release. |
255kb
pushed a commit
that referenced
this pull request
May 7, 2021
- add and split tests - update faker.js to latest version, make setSeed null safe Closes #8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computed baseUrl
Parent issue
Closes #7
Technical implementation details
baseUrlto RequestHelpersEnvironmentas a required parameter forTemplateParserandRequestHelpersTemplateParserto set theEnvironmentasnullbaseUrl