Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ipv4" helper alias use faker 'internet.ip', should use faker 'internet.ipv4' #1332

Closed
BKFlister opened this issue Mar 6, 2024 · 4 comments · Fixed by #1351
Closed

"ipv4" helper alias use faker 'internet.ip', should use faker 'internet.ipv4' #1332

BKFlister opened this issue Mar 6, 2024 · 4 comments · Fixed by #1351
Assignees
Labels
bug Something isn't working

Comments

@BKFlister
Copy link

Describe the bug
I am using the "ipv4" helper, I see it is an alias for faker 'internet.ip'
faker 'internet.ip' gives random ipv4 or ipv6

My "reading" is that the ipv4 alias should give only ipv4 adresses.
Consider changing the "ipv4" alias to use: faker 'internet.ipv4'

Steps to Reproduce

[
{{#repeat 10}}
{
"ipv4": "{{ipv4}}",
"faker ipv4": "{{faker 'internet.ipv4'}}"
}
{{/repeat}}
]

Mockoon version:
7.0.0

OS / OS version:
Mac OS 14

Thanks

@255kb 255kb added the bug Something isn't working label Mar 6, 2024
@ajatkj
Copy link
Contributor

ajatkj commented Mar 11, 2024

@255kb assign this to me please.

@ajatkj
Copy link
Contributor

ajatkj commented Mar 11, 2024

I understand documentation on website needs to be updated as well.

@255kb
Copy link
Member

255kb commented Mar 11, 2024

@ajatkj I assigned it to you, thank you!

You are right regarding the doc. You can open the PR against the release/next branch on the mockoon.com repo.

@255kb
Copy link
Member

255kb commented Apr 2, 2024

📦 This was fixed in v8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants