Bugfix/Fix server race conditions #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 757 790 +33
=========================================
+ Hits 757 790 +33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bestwebua
commented
Nov 16, 2022
bestwebua
changed the title
4 tasks
bestwebua
force-pushed
the
bugfix/fix-server-race-conditions
branch
from
137cc73
to
9eb0e70
Compare
* Resolved race conditions with R/W lock in Server * Changed lock type on messages to regular sync.Mutex * Changed all *Message methods on concrete Message type instead * Added Message#IsConsistent(), tests * Updated tests * Updated CircleCI config * Updated project documentation, changelog
bestwebua
force-pushed
the
bugfix/fix-server-race-conditions
branch
from
9eb0e70
to
ad53d87
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a sequel of #125 by @benjamin-rood and fix for: #124
ServerMessageIt will be released in a new major
smtpmockrelease.