-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: swagger/ui support #206
Conversation
Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
WalkthroughThe project has integrated Swagger using Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
error 500 in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- deps.edn (1 hunks)
- src/com/moclojer/server.clj (2 hunks)
- src/com/moclojer/specs/moclojer.clj (3 hunks)
Files skipped from review due to trivial changes (1)
- src/com/moclojer/server.clj
Additional comments: 6
src/com/moclojer/specs/moclojer.clj (4)
5-7: Added imports for Swagger support.
43-43: The
:swagger {}
map is empty. Ensure that it is intentionally left empty and not missing configuration details.44-44: Ensure that the
:body
key in thegeneric-handler
function correctly builds the response body as intended.78-88: Swagger and Swagger UI routes have been added. Verify that these routes are accessible and properly configured according to the project's standards.
deps.edn (2)
16-18: Dependencies for Swagger support have been added. Ensure that the versions are compatible with the project and that they do not introduce any conflicts with existing dependencies.
16-16: The
clj-http
dependency has been updated. Confirm that this version is compatible with the project and that all existing functionality that relies onclj-http
continues to work as expected.
@avelino I was looking to this pr but couldnt figure out yet. Not sure but it maybe we have to change more to use it with pedestal https://github.com/metosin/reitit/blob/master/examples/pedestal-swagger/src/example/server.clj |
there was too many conflict to fix it, so I'm open a new branch for this |
fixed: #205
Summary by CodeRabbit
New Features
Documentation
Refactor
Dependencies