Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markup not being preserved by setting text #40

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: markup not being preserved by setting text #40

merged 1 commit into from
Oct 30, 2023

Conversation

davidfurlong
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 66b5fd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api ✅ Ready (Inspect) Visit Preview Oct 27, 2023 7:05pm
docs ✅ Ready (Inspect) Visit Preview Oct 27, 2023 7:05pm
example-nextjs-shadcn ✅ Ready (Inspect) Visit Preview Oct 27, 2023 7:05pm

stephancill
stephancill approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@stephancill stephancill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps the ENS TLD point can be converted into a separate issue

packages/farcaster/src/structure-cast.ts Show resolved Hide resolved
@davidfurlong davidfurlong merged commit aefebce into main Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephancill stephancill stephancill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidfurlong @stephancill