fix: correct best_instance_index in batch.select_instance #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modAL/modAL/batch.py
Lines 104 to 106 in 452898f
Hi!
This pull request addresses the bug that the computed
best_instance_index
in batch.select_instance is the index of the best instance inX_pool[mask]
instead of the index inX_pool
.For this reason, the returned
X_pool[best_instance_index].reshape(1, -1)
andmask
(updated withmask[best_instance_index] = 0
) are both incorrect.