Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal queue CLI #1772

Merged
merged 6 commits into from May 1, 2024
Merged

Add modal queue CLI #1772

merged 6 commits into from May 1, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Apr 29, 2024

Adds most of what you'd want in a modal queue CLI. The only thing that's perhaps missing is a command to list the queue partitions and give you information about them (i.e., length, TTL, etc.) I think that would be nice but can't decide what a good name would be or what the API would look like, so I'll punt that until someone asks for it 馃檭.

  • Closes MOD-2810

Changelog

  • Added a command-line interface for interacting with modal.Queue objects. Run modal queue --help in your terminal to see what is available.

@mwaskom mwaskom requested a review from freider April 29, 2024 21:42
@mwaskom
Copy link
Contributor Author

mwaskom commented May 1, 2024

@prbot approve, discussed on slack

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 馃憤. @freider will follow-up review this.

@mwaskom mwaskom merged commit 390c85f into main May 1, 2024
23 checks passed
@mwaskom mwaskom deleted the michael/queue-cli branch May 1, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant