Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keep_warm from Function proto #1845

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

aksh-at
Copy link
Contributor

@aksh-at aksh-at commented May 25, 2024

Long deprecated in favor of warm_pool_size.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@mwaskom mwaskom merged commit 21667e4 into main Jun 11, 2024
23 checks passed
@mwaskom mwaskom deleted the akshat/remove-keep-warm-proto branch June 11, 2024 21:05
@@ -877,7 +877,7 @@ message Function {

uint32 concurrency_limit = 19;

bool keep_warm = 20;
reserved 20; // old fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deprecated=true]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants