Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update function call: _call_graph -> call_graph #340

Merged
merged 1 commit into from Jun 7, 2023
Merged

Update function call: _call_graph -> call_graph #340

merged 1 commit into from Jun 7, 2023

Conversation

taishikato
Copy link
Contributor

@taishikato taishikato commented Jun 6, 2023 •
edited

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

Checklist

  • Example is testable in synthetic monitoring system, or lambda-test: false is added to example frontmatter
  • Example does not require third-party dependencies to be installed locally
  • Example is documented with comments throughout, in a Literate Programming style.

Outside contributors

You're great! Thanks for your contribution.

modal-pr-review-automation[bot]
modal-pr-review-automation bot approved these changes Jun 6, 2023
View reviewed changes
Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@taishikato
Copy link
Contributor Author

Doc is here: https://modal.com/docs/reference/modal.call_graph#modalcall_graphinputinfo

@taishikato taishikato changed the title Update function call: _call_graph -> call_graph Update function call: `_call_graph -> call_graph Jun 7, 2023
@taishikato taishikato changed the title Update function call: `_call_graph -> call_graph Update function call: _call_graph -> call_graph Jun 7, 2023
thundergolfer
thundergolfer approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution 💪

@thundergolfer thundergolfer merged commit fc4044a into modal-labs:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundergolfer thundergolfer thundergolfer approved these changes

@modal-pr-review-automation modal-pr-review-automation[bot] modal-pr-review-automation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taishikato @thundergolfer