Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi cc out nrpn #62

Closed
wants to merge 4 commits into from

Conversation

AndrewCapon
Copy link

Added NRPNs for controlling parameters, including bi directional feedback.

Supports running status (data CCs 6 & 98)
7 bit values are not supported, need both CC 6 & 98.

To keep changes minimal I overloaded controller in MIDI_CC_T, this is now 16 bits, top bit signifies NRPN rather than CC.

midioutvalue is also now also 16 bits so it can hold the 14bit NRPNs value.

env var ENABLE_MIDI_NRPN needs to be non 0 to enable.

Supports  running status (data CCs 6 & 98)
7 bit values are not supported, need both CC 6 & 98.
@brummer10
Copy link

I'm impressed. Nice Work.

@AndrewCapon
Copy link
Author

AndrewCapon commented Feb 13, 2023

Do pull requests ever get merged or rejected?

I see you have 1.13 coming out soon, will these changes be merged at any point in the future?

Is it worth me getting this into a point for easy merging into 1.13 or are you guys going to do this differently or not at all?

@falkTX
Copy link
Member

falkTX commented Feb 13, 2023

There are quite a few merged PRs as seen by https://github.com/moddevices/mod-host/pulls?q=is%3Apr+is%3Aclosed

For the moment there is just not enough people and resources to devote to things not directly in scope.
But we do want to improve some MIDI things for 1.14, so I will review MIDI related changes for that next one

@AndrewCapon
Copy link
Author

AndrewCapon commented Feb 13, 2023

There are quite a few merged PRs as seen by https://github.com/moddevices/mod-host/pulls?q=is%3Apr+is%3Aclosed

For the moment there is just not enough people and resources to devote to things not directly in scope. But we do want to improve some MIDI things for 1.14, so I will review MIDI related changes for that next one

Yeah, sorry. I just looked and deleted my message, you were too quick!

@AndrewCapon
Copy link
Author

Any idea when you will be looking at 14, is it worth me getting this working on 13 or should I just stay with the old version I have with bi directional midi and wait for you to look at 14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants