Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pedal pi plugins: Gossiper, Tetr4-switch #168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SrMouraSilva
Copy link

@SrMouraSilva SrMouraSilva commented Apr 30, 2023

@falkTX
Copy link
Member

falkTX commented Feb 21, 2024

Hi, I would love to come back to this and your plugins.
Previously I told you it was best to wait until the juce situation was sorted on MOD side, which is done now, but checking your plugin code I see you do not use juce at all.

So the line in your mk file here is not needed and actually confusing:

PEDAL_PI_PLUGINS_CONF_OPTS = -DCMAKE_TOOLCHAIN_FILE=$(JUCE6_TOOLCHAIN_FILE) -DSKIP_LV2_TTL_GENERATOR=ON

What is the state of the plugins? any outstanding bugs?

For the gossiper plugin, I still maintain the stance that plugins cannot/wont show HMI popups unless they have something addressed to the HMI first.
If that is something you are ok with, we can proceed with that plugin too.

Also, the gossiper plugin only makes sense on units with HMI widgets, correct? So if pushing to the store we skip Duo units as it does not have the feature.

@SrMouraSilva
Copy link
Author

What is the state of the plugins? any outstanding bugs?

I consider that Tetr4Switch is fine.

Related to Gossiper, I noticed that sometimes, the first popup don't show. I am not sure if is something related to my code (which is the most probable) or something related to the Midi device.

Also related to Gossiper, I create some text parameters for customizing popup text.
https://github.com/SrMouraSilva/plugins-lv2/blob/master/plugins/resources/gossiper.lv2/gossiper.ttl#L393-L421
But I didn't finished because I don't know how to do it. I you have any tip, like a sample code, I will appreciate so much!

For the gossiper plugin, I still maintain the stance that plugins cannot/wont show HMI popups unless they have something addressed to the HMI first.
If that is something you are ok with, we can proceed with that plugin too.

I am ok with it.

Also, the gossiper plugin only makes sense on units with HMI widgets, correct? So if pushing to the store we skip Duo units as it does not have the feature.

Yes, I suppose that it will not be useful for this devices.

@SrMouraSilva
Copy link
Author

SrMouraSilva commented Feb 26, 2024

So the line in your mk file here is not needed and actually confusing:

PEDAL_PI_PLUGINS_CONF_OPTS = -DCMAKE_TOOLCHAIN_FILE=$(JUCE6_TOOLCHAIN_FILE) -DSKIP_LV2_TTL_GENERATOR=ON

I update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants